@behnazh after our conversation today we could add after these two lines

the following

ifeq ($(PACKAGE_VERSION),unknown)
  $(warning Unable to determine package version, proceeding anyway)
endif

That way, a user shouldn’t be surprised anymore if "unknown" sneaks into file names.

@behnazh after our conversation today we could add after these two lines

python-package-template/Makefile

Lines 6 to 8 in 66d2e0d

	# Set the package's name and version for use throughout the Makefile.
	PACKAGE_NAME := package
	PACKAGE_VERSION := $(shell python -c $$'try: import $(PACKAGE_NAME); print($(PACKAGE_NAME).__version__);\nexcept: print("unknown");')

the following

ifeq ($(PACKAGE_VERSION),unknown)
  $(warning Unable to determine package version, proceeding anyway)
endif

That way, a user shouldn’t be surprised anymore if "unknown" sneaks into file names.

Shouldn't we exit with a failure when package version is "unknown"?

Shouldn't we exit with a failure when package version is "unknown"?

Thing is that "unknown" is valid when running make venv and make setup. We could add more checks to exclude these two goals, or issue a warning instead of error & exit.

We could add more checks to exclude these two goals, or issue a warning instead of error & exit.

No, I think the code as it is captures the issues and we don't need more warnings.